feat(responsive): add support for non-FrameworkElement #1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xiaoy312
force-pushed
the
dev/xygu/20240327/responsive-columndef-and-inlines
branch
3 times, most recently
from
84eabf5
to
cf85f87
Compare
agneszitte
approved these changes
Mar 28, 2024
Xiaoy312
force-pushed
the
dev/xygu/20240327/responsive-columndef-and-inlines
branch
2 times, most recently
from
5c24d2d
to
0b06d70
Compare
pedrojesus-work
approved these changes
Mar 28, 2024
Xiaoy312
force-pushed
the
dev/xygu/20240327/responsive-columndef-and-inlines
branch
from
0b06d70
to
d3bb48b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #950
PR Type
What kind of change does this PR introduce?
What is the current behavior?
previously ResponsiveExpression didnt support non-FrameworkElement targets such as Grid.ColumnDefinitions or TextBlock.Inlines.
What is the new behavior?
^ they are now supported.
PR Checklist
Please check if your PR fulfills the following requirements: