fix: Ensure all progressrings stop #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazo0
approved these changes
Apr 5, 2024
nickrandolph
force-pushed
the
dev/nr/progressringstoprunningplease
branch
from
4e5e6a0
to
3b2ae6d
Compare
|
@Mergifyio backport release/stable/6.0 |
✅ Backports have been created
|
agneszitte
reviewed
Apr 5, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
18 tasks
jeromelaban
added a commit
that referenced
this pull request
Apr 6, 2024
….0/pr-1100 fix: Ensure all progressrings stop (backport #1100)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): #1099
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Progressring in loadingcontenttemplate not being stopped - the search was stopping at the contenttemplate, rather than interrogating all children
What is the new behavior?
Progressring is being stopped
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Internal Issue (If applicable):