Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ArgumentOutOfRangeException when adding PrimaryCommand to NavBar #1161

Merged
merged 2 commits into from
Jun 15, 2024

Conversation

Kunal22shah
Copy link
Contributor

GitHub Issue (If applicable): #1150

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@Kunal22shah Kunal22shah self-assigned this Jun 13, 2024
@kazo0
Copy link
Contributor

kazo0 commented Jun 13, 2024

@Kunal22shah make sure to use the keyword closes or fixes before the link to the affected issue number:

image

If you change it to

closes #1150

Then the PR will be linked to the issue and it will auto-close the issue when this PR is merged

Co-authored-by: Xiaotian Gu <xiaoyao312@gmail.com>
@kazo0 kazo0 merged commit cdc2afd into main Jun 15, 2024
25 checks passed
@kazo0 kazo0 deleted the dev/ks/navBar-AoorException-fix branch June 15, 2024 00:55
Copy link

welcome bot commented Jun 15, 2024

Congrats on your first pull-request! We ❤ the people who are involved in this project, and we’d love to pay it forward by sending you some swag. If you have any feedback (or ideas how to improve Uno as a open-source project) please open a feedback issue.
giphy
Merci beaucoup 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArgumentOutOfRangeException while adding a PrimaryCommand in the NavigationBar control by code
3 participants