fix: Get the correct file path

[eriklimakc]

GitHub Issue (If applicable): #1165

PR Type

What kind of change does this PR introduce?

• Bugfix

What is the current behavior?

The url being returned is file:\C:\C\1165\UnoApp1\UnoApp1\bin\Debug\net8.0-windows10.0.19041\AppxManifest.xml. When File.Exist uses that url, it returns false due to the "file" prefix.

What is the new behavior?

No "file" prefix.

PR Checklist

Please check if your PR fulfills the following requirements:

• Tested code with current supported SDKs
• Tested the changes where applicable:
  • UWP
  • WinUI
  • iOS
  • Android
  • WASM
  • MacOS
• Updated the documentation as needed:
  • General Doc Update
  • Controls Doc Update
  • Extensions Doc Update
  • controls-styles.md
  • lightweight-styling.md (LightWeight Styling Resource Keys)
• Runtime Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
• Contains NO breaking changes
• Associated with an issue (GitHub or internal)
• Commits must be following the Conventional Commits specification.

Other information

Internal Issue (If applicable):

[Xiaoy312]

we should probably wrap it in #If WINDOWS
given the problem is only affecting windows unpackaged
---
or, did you checked that this doesnt break/isnt reached on skia/wasm?

[kazo0]

@eriklimakc Can you double check the comment from @Xiaoy312 and check if either the change works fine for skia/wasm or if we need to wrap this in #if WINDOWS

[eriklimakc]

we should probably wrap it in #If WINDOWS given the problem is only affecting windows unpackaged --- or, did you checked that this doesnt break/isnt reached on skia/wasm?

Skia: On skia the prefix 'file:' is also present on codebase and the code added works fine. It didn't change the behavior, since the file on the check below doesn't exist, so it loads from StorageFile.GetFileFromApplicationUriAsync(new Uri($"ms-appx:///{fileName}")).

uno.toolkit.ui/src/Uno.Toolkit.UI/Controls/ExtendedSplashScreen/ExtendedSplashScreen.Windows.crossruntime.cs

Line 264 in 43d4127

if (File.Exists(manifestPath))

uno.toolkit.ui/src/Uno.Toolkit.UI/Controls/ExtendedSplashScreen/ExtendedSplashScreen.Windows.crossruntime.cs

Lines 274 to 275 in 43d4127

	var storageFile = await StorageFile.GetFileFromApplicationUriAsync(new Uri($"ms-appx:///{fileName}"));
	filePath = storageFile.Path;

Wasm: I can't debug wasm, but I used typeof(ExtendedSplashScreen).Log()... to see if the code is reached, but I didn't see any of the logs I added on the Console. I didn't notice any change on the behavior.

I also downloaded the artifacts from this PR and used on a new uno app and the app didn't show any problems.

Are there other tests I could do to ensure this will run smoothly?

cc @Xiaoy312 @kazo0

[kazo0]

@eriklimakc

I would say we should just do what @Xiaoy312 mentioned and wrap this specific change in #If WINDOWS just so we can be sure we aren't changing the logic for other platforms

[kazo0]

@Mergifyio backport release/stable/6.1

[mergify]

backport release/stable/6.1

✅ Backports have been created

• #1221 fix: Get the correct file path (backport #1211) has been created for branch release/stable/6.1