fix: ancestor-binding initial value type incompatibility #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xiaoy312
force-pushed
the
dev/xygu/20240806/ancestor-binding-initial-value
branch
from
0465060
to
22013d1
Compare
|
@Mergifyio backport release/stable/6.1 |
✅ Backports have been created
|
Xiaoy312
force-pushed
the
dev/xygu/20240806/ancestor-binding-initial-value
branch
from
22013d1
to
148925a
Compare
kazo0
approved these changes
Aug 9, 2024
mergify bot
pushed a commit
that referenced
this pull request
Aug 9, 2024
(cherry picked from commit 65316fa)
18 tasks
kazo0
pushed a commit
that referenced
this pull request
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #1218, closes #1219
PR Type
What kind of change does this PR introduce?
What is the current behavior?
AncestorBinding when used on non-reference type dp would cause a COMException. This is due to it returning
nullas initial default value, until the binding came online.What is the new behavior?
The current value will now be returned, prevent this COMException.
PR Checklist
Please check if your PR fulfills the following requirements: