Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix flaky shadow test #1241

Merged
merged 1 commit into from
Sep 13, 2024
Merged

chore: fix flaky shadow test #1241

merged 1 commit into from
Sep 13, 2024

Conversation

kazo0
Copy link
Contributor

@kazo0 kazo0 commented Sep 12, 2024

Use a fully opaque shadow to compare screenshots with

Before:
image

After:

image

@kazo0
Copy link
Contributor Author

kazo0 commented Sep 12, 2024

@Mergifyio backport release/stable/6.2

Copy link
Contributor

mergify bot commented Sep 12, 2024

backport release/stable/6.2

✅ Backports have been created

@kazo0 kazo0 enabled auto-merge (squash) September 12, 2024 19:03
@kazo0 kazo0 merged commit dc6ccef into main Sep 13, 2024
25 checks passed
@kazo0 kazo0 deleted the dev/sb/shadow-test branch September 13, 2024 02:37
mergify bot pushed a commit that referenced this pull request Sep 13, 2024
(cherry picked from commit dc6ccef)

# Conflicts:
#	src/Uno.Toolkit.UITest/Controls/ShadowContainer/Given_ShadowContainer2.cs
kazo0 added a commit that referenced this pull request Sep 17, 2024
(cherry picked from commit dc6ccef)

# Conflicts:
#	src/Uno.Toolkit.UITest/Controls/ShadowContainer/Given_ShadowContainer2.cs
kazo0 pushed a commit that referenced this pull request Sep 17, 2024
Co-authored-by: Steve Bilogan <steve.bilogan@gmail.com>
Co-authored-by: Jérôme Laban <jlaban@gmail.com>
fix flaky shadow test (#1241)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants