-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add SafeArea #292
feat: Add SafeArea #292
Conversation
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net |
.../Uno.Toolkit.WinUI.Samples.Windows.Package/Uno.Toolkit.WinUI.Samples.Windows.Package.wapproj
Outdated
Show resolved
Hide resolved
And we can't exit the safe area sample :) |
6791d28
to
440bca2
Compare
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net |
samples/Uno.Toolkit.Samples/Uno.Toolkit.Samples.Shared/Helpers/VisualTreeAncestryHelper.cs
Outdated
Show resolved
Hide resolved
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net |
1 similar comment
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net |
047c650
to
f12a7e9
Compare
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net |
16 similar comments
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are some files saved with xamlstyler indentation style: spaces, rather than tabs
and cs files with mixed tab characters too, get in the habit of hitting ctrl+k,d
edit: squash your "ci: fix"es
samples/Uno.Toolkit.Samples/Uno.Toolkit.Samples.Shared/App.xaml.Navigation.cs
Outdated
Show resolved
Hide resolved
samples/Uno.Toolkit.Samples/Uno.Toolkit.Samples.Shared/App.xaml.cs
Outdated
Show resolved
Hide resolved
....Samples/Uno.Toolkit.Samples.Shared/Content/NestedSamples/SafeAreaSamplePage_NestedPage.xaml
Outdated
Show resolved
Hide resolved
...it.Samples/Uno.Toolkit.Samples.Shared/Content/NestedSamples/SafeArea_Control_NestedPage.xaml
Outdated
Show resolved
Hide resolved
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
440c962
to
080abdd
Compare
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net |
1 similar comment
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net |
f59dbfd
to
5db338c
Compare
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net |
1 similar comment
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net |
2dd75f5
to
d77de82
Compare
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net |
2 similar comments
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net |
f57d369
to
3bfa0e3
Compare
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net |
935617b
to
c77ade5
Compare
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net |
1 similar comment
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net |
59ede90
to
0ed88d9
Compare
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net |
d70322f
to
be47ad1
Compare
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net |
1 similar comment
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net |
0a72125
to
db053a9
Compare
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net |
1 similar comment
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net |
closes #302
PR Type
What kind of change does this PR introduce?
TODO: Add gifs/screenshots