-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(AutoLayout): Properly call the UpdateAutoLayout method during the OnLoaded #462
Conversation
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-462.eastus2.azurestaticapps.net |
…e updating the layout (#458)
68d9a76
to
ddb411b
Compare
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-462.eastus2.azurestaticapps.net |
@agneszitte-nventive could this be tested with a runtime test? |
@jeromelaban I will verify but I think there is maybe a way. I will do another PR to add some tests if it is possible |
…e updating the layout (unoplatform#458) (unoplatform#462)
@jeromelaban / @kazo0 I will wait for this PR #471 to be merged first in order to add a runtime test for the AutoLayout control. |
GitHub Issue (If applicable): #https://github.com/unoplatform/uno.chefs/issues/178
PR Type
What kind of change does this PR introduce?
What is the current behavior?
AutoLayout IsLoaded return false for all platforms except WinUI
(Explain by the fact that the sequence of events is different between Windows and WinUI)
What is the new behavior?
Properly call the UpdateAutoLayout method during the OnLoaded that way IsLoaded is "true" for all platforms at the correct time
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Internal Issue (If applicable):