Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autolayout): padding rules when all children are strech #475

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

Robert-Louis
Copy link
Contributor

@Robert-Louis Robert-Louis commented Feb 17, 2023

GitHub Issue (If applicable): unoplatform/Uno.Figma#1263, #459

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

  • Padding didn't behave like in figma for padding and stretch children

What is the new behavior?

  • Padding behave as expected when one parent is stretch

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@agneszitte agneszitte enabled auto-merge (squash) February 20, 2023 15:12
@agneszitte agneszitte merged commit 451eb23 into main Feb 20, 2023
@agneszitte agneszitte deleted the dev/rlm/autolayout-padding branch February 20, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants