-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: TabBar issues #502
fix: TabBar issues #502
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tests can be added for these changes ?
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-502.eastus2.azurestaticapps.net |
I'm not sure how to test the sliding indicator, need to think about it |
set selection index, and |
yeah thats what i am doing now, i was thinking more about the "in between" sliding when you are scrolling a FlipView and it should slide along based on the scroll offset. Testing for the indicator moving from item to item on selection is fine but the issue here was that it wasn't properly sliding to its destination |
src/Uno.Toolkit.UI/Controls/TabBar/TabBarSelectionIndicatorPresenter.cs
Outdated
Show resolved
Hide resolved
1ab90ba
to
d7926eb
Compare
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-502.eastus2.azurestaticapps.net |
1 similar comment
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-502.eastus2.azurestaticapps.net |
883a859
to
862761e
Compare
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-502.eastus2.azurestaticapps.net |
0140068
to
5ffb6f1
Compare
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-502.eastus2.azurestaticapps.net |
1 similar comment
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-502.eastus2.azurestaticapps.net |
closes #501
PR Type
What kind of change does this PR introduce?
Changes