fix: Ensure NavBar properly displays MainCommand button in all scenarios #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-534.eastus2.azurestaticapps.net |
kazo0
changed the title
Xiaoy312
approved these changes
Apr 11, 2023
src/Uno.Toolkit.UI/Controls/NavigationBar/NavigationBarNavigationItemRenderer.iOS.cs
Outdated
Show resolved
Hide resolved
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-534.eastus2.azurestaticapps.net |
kazo0
force-pushed
the
dev/sb/ios-nav-bar
branch
from
730e3bc
to
66f8290
Compare
kazo0
force-pushed
the
dev/sb/ios-nav-bar
branch
from
b09c12e
to
fcc0272
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-534.eastus2.azurestaticapps.net |
1 similar comment
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-534.eastus2.azurestaticapps.net |
agneszitte
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to https://github.com/unoplatform/uno.chefs/issues/128
PR Type
What kind of change does this PR introduce?
For cases where the NavBar's MainCommand should still be visible even if the BackStack is empty (such as modal pages where the MainCommand should be visible in order to close the flyout), we should be able to define the MainCommand.Icon and have the button visible in the NavBar like below:
We should also now be able to properly display the proper text on the NavBar's MainCommand using its Content or Label property
<MainCommand Label="Return" />should give: