Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding splash screen to skia and wasm targets #535

Merged
merged 9 commits into from
Apr 19, 2023
Merged

feat: Adding splash screen to skia and wasm targets #535

merged 9 commits into from
Apr 19, 2023

Conversation

nickrandolph
Copy link
Contributor

@nickrandolph nickrandolph commented Apr 6, 2023 •
edited
Loading

GitHub Issue (If applicable): closes #533, closes #529

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

Extended splash screen doesn't load on skia or wasm targets

What is the new behavior?

Skia and WASM now supported
Added Platforms property that allows native splash screen loading to be configured on individual platforms

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@nickrandolph nickrandolph force-pushed the dev/nr/splashskiawasm branch 3 times, most recently from 03e5131 to 46ec085 Compare April 6, 2023 03:07
@github-actions
Copy link

github-actions bot commented Apr 13, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-535.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Apr 13, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-535.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Apr 13, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-535.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Apr 18, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-535.eastus2.azurestaticapps.net

2 similar comments
@github-actions
Copy link

github-actions bot commented Apr 18, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-535.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Apr 18, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-535.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Apr 18, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-535.eastus2.azurestaticapps.net

@nickrandolph @Youssef1313
docs: Fix
4312c53 
Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
@github-actions
Copy link

github-actions bot commented Apr 19, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-535.eastus2.azurestaticapps.net

@nickrandolph nickrandolph merged commit 0a662ee into main Apr 19, 2023
@nickrandolph nickrandolph deleted the dev/nr/splashskiawasm branch April 19, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youssef1313 Youssef1313 Youssef1313 left review comments

@kazo0 kazo0 kazo0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nickrandolph @kazo0 @Youssef1313