feat: Add IndicatorPlacement to TabBar #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazo0
force-pushed
the
dev/sb/tabbar-indicator-placement
branch
from
4434a92
to
0d6e33c
Compare
agneszitte
reviewed
Apr 12, 2023
kazo0
force-pushed
the
dev/sb/tabbar-indicator-placement
branch
from
45e9af8
to
82cb82f
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kazo0
force-pushed
the
dev/sb/tabbar-indicator-placement
branch
from
396c9e4
to
f9de03c
Compare
Xiaoy312
reviewed
Apr 17, 2023
Xiaoy312
reviewed
Apr 17, 2023
Xiaoy312
reviewed
Apr 17, 2023
Xiaoy312
reviewed
Apr 17, 2023
Xiaoy312
reviewed
Apr 17, 2023
Xiaoy312
reviewed
Apr 17, 2023
Xiaoy312
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related https://github.com/unoplatform/uno.chefs/issues/382
PR Type
What kind of change does this PR introduce?
Adds ability to drive whether or not the selection indicator for a
TabBarwill display above over below the content of theTabBarWith
IndicatorPlacement.Above:With
IndicatorPlacement.Below: