Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NavigationBar): Ensure proper iOS back button behavior #548

Merged
merged 4 commits into from
Apr 25, 2023
Merged

fix(NavigationBar): Ensure proper iOS back button behavior #548

merged 4 commits into from
Apr 25, 2023

Conversation

kazo0
Copy link
Contributor

@kazo0 kazo0 commented Apr 21, 2023 •
edited
Loading

NavigationBars wrapped in an AutoLayout on iOS can result in a missing Back button icon/label.

We need to ensure that we are rendering the Page's NavigationBar with the proper instance of the previous ViewController's UINavigationItem

@kazo0 kazo0 force-pushed the dev/sb/ios-nav-bar-render branch 3 times, most recently from 019cf2f to 83281ba Compare April 21, 2023 12:30
Xiaoy312
Xiaoy312 reviewed Apr 21, 2023
View reviewed changes
Copy link
Contributor

@Xiaoy312 Xiaoy312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we split the setup/build changes from the navigation bar ones?
ideally in a different pr, at least minimally a different commit

@github-actions
Copy link

github-actions bot commented Apr 21, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-548.eastus2.azurestaticapps.net

@kazo0
Copy link
Contributor Author

kazo0 commented Apr 21, 2023 •
edited
Loading

can we split the setup/build changes from the navigation bar ones? ideally in a different pr, at least minimally a different commit

@Xiaoy312 : #549

@kazo0 kazo0 force-pushed the dev/sb/ios-nav-bar-render branch from 5de9918 to 5f6953c Compare April 21, 2023 15:43
@github-actions
Copy link

github-actions bot commented Apr 21, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-548.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Apr 21, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-548.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Apr 21, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-548.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Apr 22, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-548.eastus2.azurestaticapps.net

@kazo0 kazo0 force-pushed the dev/sb/ios-nav-bar-render branch from 2204aa4 to eb596c0 Compare April 23, 2023 12:22
@github-actions
Copy link

github-actions bot commented Apr 23, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-548.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Apr 23, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-548.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Apr 23, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-548.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Apr 25, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-548.eastus2.azurestaticapps.net

@kazo0 kazo0 merged commit d70e30e into main Apr 25, 2023
@kazo0 kazo0 deleted the dev/sb/ios-nav-bar-render branch April 25, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xiaoy312 Xiaoy312 Xiaoy312 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kazo0 @Xiaoy312