fix: Loading appxmanifest.xml and package.appxmanifest from file or embedded resource #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickrandolph
force-pushed
the
dev/nr/issue563
branch
from
3cfd6eb
to
03b3764
Compare
Xiaoy312
approved these changes
May 5, 2023
src/Uno.Toolkit.UI/Controls/ExtendedSplashScreen/ExtendedSplashScreen.Windows.NetStandard.cs
Show resolved
Hide resolved
src/Uno.Toolkit.UI/Controls/ExtendedSplashScreen/ExtendedSplashScreen.Windows.NetStandard.cs
Outdated
Show resolved
Hide resolved
src/Uno.Toolkit.UI/Controls/ExtendedSplashScreen/ExtendedSplashScreen.Windows.NetStandard.cs
Outdated
Show resolved
Hide resolved
src/Uno.Toolkit.UI/Controls/ExtendedSplashScreen/ExtendedSplashScreen.Windows.NetStandard.cs
Outdated
Show resolved
Hide resolved
src/Uno.Toolkit.UI/Controls/ExtendedSplashScreen/ExtendedSplashScreen.Windows.NetStandard.cs
Outdated
Show resolved
Hide resolved
src/Uno.Toolkit.UI/Controls/ExtendedSplashScreen/ExtendedSplashScreen.Windows.NetStandard.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Xiaotian Gu <xiaoyao312@gmail.com>
Co-authored-by: Xiaotian Gu <xiaoyao312@gmail.com>
Co-authored-by: Xiaotian Gu <xiaoyao312@gmail.com>
Co-authored-by: Xiaotian Gu <xiaoyao312@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): #563
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Doesn't load from file system when unpackaged WinUI
What is the new behavior?
manifest file loaded from file system as fall back from applicationdata
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Internal Issue (If applicable):