fix: NavBar Icon fixes #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-589.eastus2.azurestaticapps.net |
ajpinedam
approved these changes
Jun 13, 2023
src/Uno.Toolkit.UI/Controls/NavigationBar/NavigationAppBarButtonRenderer.Android.cs
Show resolved
Hide resolved
src/Uno.Toolkit.UI/Controls/NavigationBar/NavigationAppBarButtonRenderer.Android.cs
Outdated
Show resolved
Hide resolved
kazo0
force-pushed
the
dev/sb/navbar-icons
branch
from
996c90e
to
f871374
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-589.eastus2.azurestaticapps.net |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related https://github.com/unoplatform/nventive-private/issues/487
related unoplatform/uno#8996
fixes #586
Fix error when using non-supported appbarbutton iconelement
What is the current behavior?
Setting the Foreground property of a BitmapIcon has no effect when being used within the native renderers for CommandBar on iOS/Android
What is the new behavior?
Foreground on BitmapIcon is respected and takes precedence over the Foreground of the AppBarButton