Small improvements #701
Merged
Small improvements #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
reviewed
Aug 8, 2023
pictos
force-pushed
the
pj/fixing-record-struct
branch
from
aec4923
to
3f50db8
Compare
pictos
force-pushed
the
pj/fixing-record-struct
branch
from
3f50db8
to
c3e6509
Compare
Xiaoy312
approved these changes
Aug 17, 2023
|
@Mergifyio backport legacy/3x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 21, 2023
(cherry picked from commit 1633a92)
agneszitte
pushed a commit
that referenced
this pull request
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not using the template, because I added two small fixes on the code.
SKShadowto be areadonly record struct, I believe we want it to be immutable, andrecord structisn't immutable, we to add thereadonlymodifier;Array.Empty<T>to avoid allocations.