Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Templatebound Margin to remove hardcoded margin #715

Merged

Conversation

nguyeenvy
Copy link
Contributor

@nguyeenvy nguyeenvy commented Aug 10, 2023

closes #706
GitHub Issue (If applicable): #706

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Refactoring (no functional changes, no api changes)

What is the current behavior?

Adding Elevated CardContentControls to an ItemsRepeater that defines its own Spacing between items causes more spacing between the cards than intended because of the margin applied to the ElevatedView

What is the new behavior?

The margin applied to the ElevatedView is now templatebound to Margin so we can set Margin=0 whenever we just want to use Spacing of the container around the CardContentControls.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@nguyeenvy nguyeenvy self-assigned this Aug 10, 2023
@nguyeenvy nguyeenvy requested a review from kazo0 August 10, 2023 18:46
@pictos
Copy link
Contributor

pictos commented Aug 11, 2023

@nguyeenvy can you point where is/are the change(s), there's a lot of noise caused by code-style

@agneszitte
Copy link
Contributor

@nguyeenvy can you point where is/are the change(s), there's a lot of noise caused by code-style

@pictos As a tip when reviewing directly on GitHub you can use the "Hide whitespace" option
Yy26r

@nguyeenvy
Copy link
Contributor Author

The main changes are at lines 218 and 223.

@agneszitte agneszitte merged commit df9e747 into main Aug 30, 2023
15 checks passed
@agneszitte agneszitte deleted the dev/vyng/Hardcoded-Margin-ElevatedCardContentControl branch August 30, 2023 00:25
@agneszitte
Copy link
Contributor

@Mergifyio backport legacy/3x release/stable/3.1

@mergify
Copy link
Contributor

mergify bot commented Aug 30, 2023

backport legacy/3x release/stable/3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 30, 2023
(cherry picked from commit df9e747)

# Conflicts:
#	src/library/Uno.Toolkit.Material/Styles/Controls/v2/CardContentControl.xaml
mergify bot pushed a commit that referenced this pull request Aug 30, 2023
(cherry picked from commit df9e747)

# Conflicts:
#	src/library/Uno.Toolkit.Material/Styles/Controls/v2/CardContentControl.xaml
jeromelaban pushed a commit that referenced this pull request Aug 30, 2023
(cherry picked from commit df9e747)

# Conflicts:
#	src/library/Uno.Toolkit.Material/Styles/Controls/v2/CardContentControl.xaml
agneszitte added a commit that referenced this pull request Aug 31, 2023
(cherry picked from commit df9e747)

# Conflicts:
# src/library/Uno.Toolkit.Material/Styles/Controls/v2/CardContentControl.xaml
agneszitte added a commit that referenced this pull request Aug 31, 2023
(cherry picked from commit df9e747)

# Conflicts:
# src/library/Uno.Toolkit.Material/Styles/Controls/v2/CardContentControl.xaml
agneszitte added a commit that referenced this pull request Aug 31, 2023
agneszitte added a commit that referenced this pull request Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CardContentControl][Material] Elevated CardContentControl adds a hardcoded margin
4 participants