fix(AutoLayout): check for filledChildrenCount was inverse #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robert-Louis
requested review from
agneszitte,
Xiaoy312,
carldebilly and
kazo0
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-857.eastus2.azurestaticapps.net |
kazo0
reviewed
Sep 27, 2023
Robert-Louis
force-pushed
the
dev/rlm/autolayout-visibility
branch
from
47b65f1
to
a1ad544
Compare
carldebilly
approved these changes
Sep 28, 2023
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-857.eastus2.azurestaticapps.net |
kazo0
approved these changes
Sep 28, 2023
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): #851
PR Type
What kind of change does this PR introduce?
What is the current behavior?
fill children was given the appropriate size information
What is the new behavior?
fill children are properly count and assigned size
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Internal Issue (If applicable):