Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

responsive enhancements #944

Merged
merged 8 commits into from
Dec 6, 2023
Merged

responsive enhancements #944

merged 8 commits into from
Dec 6, 2023

Conversation

Xiaoy312
Copy link
Contributor

@Xiaoy312 Xiaoy312 commented Dec 4, 2023 •
edited
Loading

GitHub Issue (If applicable): closes #945, closes #941

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

@Xiaoy312
Copy link
Contributor Author

Xiaoy312 commented Dec 4, 2023 •
edited
Loading

todo:

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-944.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20231204/responsive-enhancements branch 3 times, most recently from 31ce609 to 47941c9 Compare December 5, 2023 23:06
@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20231204/responsive-enhancements branch from df6b28e to 11e8909 Compare December 6, 2023 15:39
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-944.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 marked this pull request as ready for review December 6, 2023 16:54
@Xiaoy312 Xiaoy312 changed the title wip: responsive enhancements responsive enhancements Dec 6, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-944.eastus2.azurestaticapps.net

kazo0
kazo0 approved these changes Dec 6, 2023
View reviewed changes
doc/controls/ResponsiveView.md Show resolved Hide resolved
kazo0
kazo0 reviewed Dec 6, 2023
View reviewed changes
Copy link
Contributor

@kazo0 kazo0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need runtime tests for the layout resolution and type conversion

eriklimakc
eriklimakc requested changes Dec 6, 2023
View reviewed changes
doc/helpers/responsive-extension.md Outdated Show resolved Hide resolved
doc/helpers/responsive-extension.md Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-944.eastus2.azurestaticapps.net

@Xiaoy312 @silviuo @eriklimakc
chore: Apply suggestions from code review
ddfa70d 
Co-authored-by: Silviu Obreja <silviuo@users.noreply.github.com>
Co-authored-by: Érik Lima <114886335+eriklimakc@users.noreply.github.com>
@Xiaoy312
Copy link
Contributor Author

Xiaoy312 commented Dec 6, 2023

We'll need runtime tests for the layout resolution and type conversion

ill work on that, in the follow pr for performance
type conversion cant exactly be tested, since xaml parsing of markup is not supported: unoplatform/uno#14620

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-944.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20231204/responsive-enhancements branch from 2422e45 to 5687074 Compare December 6, 2023 19:21
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-944.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 merged commit 149ac82 into main Dec 6, 2023
24 checks passed
@Xiaoy312 Xiaoy312 deleted the dev/xygu/20231204/responsive-enhancements branch December 6, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazo0 kazo0 kazo0 approved these changes

@eriklimakc eriklimakc eriklimakc approved these changes

@agneszitte agneszitte agneszitte approved these changes

@silviuo silviuo silviuo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ResponsiveLayout as static resource Handle type conversion for Responsive markup extension
5 participants
@Xiaoy312 @kazo0 @silviuo @agneszitte @eriklimakc