Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Navbar Icons sizing #976

Merged
merged 2 commits into from
Jan 30, 2024
Merged

fix: Navbar Icons sizing #976

merged 2 commits into from
Jan 30, 2024

Conversation

vatsashah45
Copy link
Contributor

@vatsashah45 vatsashah45 commented Dec 15, 2023

closes #877

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@vatsashah45 vatsashah45 self-assigned this Dec 15, 2023
@kazo0
Copy link
Contributor

kazo0 commented Dec 15, 2023

@vatsashah45 would you be able to provide a screenshot overlay similar to what was in the original issue:
image

So we can see the new changes and how they align with the design?

@agneszitte
Copy link
Contributor

@vatsashah45 would you be able to provide a screenshot overlay similar to what was in the original issue:
So we can see the new changes and how they align with the design?

@vatsashah45 any update on the overlay screenshot please?

@kazo0
Copy link
Contributor

kazo0 commented Jan 29, 2024

Verified that this is what we want

@kazo0 kazo0 enabled auto-merge (squash) January 29, 2024 18:49
@kazo0 kazo0 merged commit ceb1cb1 into main Jan 30, 2024
26 checks passed
@kazo0 kazo0 deleted the dev/vs/fix-NavBarIcons branch January 30, 2024 19:02
@kazo0
Copy link
Contributor

kazo0 commented Jan 31, 2024

@Mergifyio backport release/stable/5.1

Copy link
Contributor

mergify bot commented Jan 31, 2024

backport release/stable/5.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 31, 2024
* fix: Navbar Icons sizing

* fix: sizing

---------

Co-authored-by: Steve Bilogan <steve.bilogan@gmail.com>
(cherry picked from commit ceb1cb1)
carldebilly added a commit that referenced this pull request Feb 1, 2024
….1/pr-976

fix: Navbar Icons sizing (backport #976)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Material][Non-Mobile] NavigationBar Icons do not match design sizes
3 participants