Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tabbar): add surface tint layer to material bottom/vertical navigation tabbar #987

Merged
merged 1 commit into from
Dec 22, 2023
Merged

fix(tabbar): add surface tint layer to material bottom/vertical navigation tabbar #987

merged 1 commit into from
Dec 22, 2023

Conversation

kazo0
Copy link
Contributor

@kazo0 kazo0 commented Dec 21, 2023 •
edited
Loading

Old:

image)

New:

image

@kazo0 kazo0 enabled auto-merge (squash) December 21, 2023 22:12
agneszitte
agneszitte reviewed Dec 21, 2023
View reviewed changes
Copy link
Contributor

@agneszitte agneszitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing doc updates with these changes no @kazo0, @Xiaoy312 ?

@kazo0
Copy link
Contributor Author

kazo0 commented Dec 21, 2023

Missing doc updates with these changes no @kazo0, @Xiaoy312 ?

@agneszitte I added the new resources to the docs, no?

@agneszitte
Copy link
Contributor

agneszitte commented Dec 21, 2023 •
edited
Loading

Missing doc updates with these changes no @kazo0, @Xiaoy312 ?

@agneszitte I added the new resources to the docs, no?

For example this screenshot should be updated with the tint no ?
image

@kazo0 kazo0 merged commit 130f102 into main Dec 22, 2023
24 checks passed
@kazo0 kazo0 deleted the dev/sb/surface-tint-tabbar branch December 22, 2023 00:59
@kazo0 kazo0 mentioned this pull request Jan 25, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agneszitte agneszitte agneszitte left review comments

@carldebilly carldebilly carldebilly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kazo0 @agneszitte @carldebilly