Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add SafeArea #292

Merged
merged 1 commit into from
Sep 8, 2022
Merged

feat: Add SafeArea #292

merged 1 commit into from
Sep 8, 2022

Conversation

kazo0
Copy link
Contributor

@kazo0 kazo0 commented Aug 24, 2022 •
edited
Loading

closes #302

PR Type

What kind of change does this PR introduce?

  • Feature

TODO: Add gifs/screenshots

@github-actions
Copy link

github-actions bot commented Aug 24, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net

@jeromelaban
Copy link
Member

And we can't exit the safe area sample :)

@github-actions
Copy link

github-actions bot commented Aug 31, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net

Xiaoy312
Xiaoy312 reviewed Aug 31, 2022
View reviewed changes
samples/Uno.Toolkit.Samples/Uno.Toolkit.Samples.Shared/Helpers/VisualTreeAncestryHelper.cs Outdated Show resolved Hide resolved
src/Uno.Toolkit.UI/Controls/SafeArea/SafeArea.cs Outdated Show resolved Hide resolved
src/Uno.Toolkit.UI/Controls/SafeArea/SafeArea.cs Outdated Show resolved Hide resolved
src/Uno.Toolkit.UI/Controls/SafeArea/SafeArea.cs Outdated Show resolved Hide resolved
src/Uno.Toolkit.UI/Helpers/PaddingHelper.cs Outdated Show resolved Hide resolved
src/Uno.Toolkit.UI/Extensions/DependencyObjectExtensions.cs Outdated Show resolved Hide resolved
src/Uno.Toolkit.UI/Controls/SafeArea/SafeArea.cs Outdated Show resolved Hide resolved
src/Uno.Toolkit.UI/Controls/SafeArea/SafeArea.cs Show resolved Hide resolved
src/Uno.Toolkit.UI/Extensions/RectExtensions.cs Outdated Show resolved Hide resolved
src/Uno.Toolkit.UI/Extensions/RectExtensions.cs Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Aug 31, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Sep 6, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net

@kazo0 kazo0 marked this pull request as ready for review September 6, 2022 12:13
@github-actions
Copy link

github-actions bot commented Sep 6, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net

16 similar comments
@github-actions
Copy link

github-actions bot commented Sep 6, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Sep 6, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Sep 6, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Sep 6, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Sep 6, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Sep 6, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Sep 6, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Sep 6, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Sep 6, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Sep 6, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Sep 6, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Sep 6, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Sep 6, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Sep 6, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Sep 6, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Sep 6, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net

Xiaoy312
Xiaoy312 reviewed Sep 6, 2022
View reviewed changes
Copy link
Contributor

@Xiaoy312 Xiaoy312 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are some files saved with xamlstyler indentation style: spaces, rather than tabs
and cs files with mixed tab characters too, get in the habit of hitting ctrl+k,d
edit: squash your "ci: fix"es

build/workflow/scripts/ios-uitest-run.sh Outdated Show resolved Hide resolved
samples/Uno.Toolkit.Samples/Uno.Toolkit.Samples.Shared/App.xaml.Navigation.cs Outdated Show resolved Hide resolved
samples/Uno.Toolkit.Samples/Uno.Toolkit.Samples.Shared/App.xaml.cs Outdated Show resolved Hide resolved
....Samples/Uno.Toolkit.Samples.Shared/Content/NestedSamples/SafeAreaSamplePage_NestedPage.xaml Outdated Show resolved Hide resolved
...it.Samples/Uno.Toolkit.Samples.Shared/Content/NestedSamples/SafeArea_Control_NestedPage.xaml Outdated Show resolved Hide resolved
src/Uno.Toolkit.UI/Controls/SafeArea/SafeArea.cs Outdated Show resolved Hide resolved
src/Uno.Toolkit.UITest/Controls/SafeArea/Given_SafeArea.cs Outdated Show resolved Hide resolved
src/Uno.Toolkit.UITest/Controls/SafeArea/Given_SafeArea.cs Outdated Show resolved Hide resolved
src/Uno.Toolkit.UITest/Extensions/FluentExtensions.cs Outdated Show resolved Hide resolved
src/Uno.Toolkit.UITest/Framework/ColorCodeParser.cs Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Sep 6, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net

@kazo0 kazo0 enabled auto-merge (squash) September 7, 2022 18:51
@kazo0
Copy link
Contributor Author

kazo0 commented Sep 7, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@github-actions
Copy link

github-actions bot commented Sep 7, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Sep 7, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Sep 7, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Sep 7, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Sep 8, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net

2 similar comments
@github-actions
Copy link

github-actions bot commented Sep 8, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Sep 8, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Sep 8, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Sep 8, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Sep 8, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Sep 8, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Sep 8, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Sep 8, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Sep 8, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Sep 8, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Sep 8, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-292.eastus2.azurestaticapps.net

@kazo0 kazo0 merged commit 8e1ddad into main Sep 8, 2022
@kazo0 kazo0 deleted the dev/sb/safe-area branch September 8, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromelaban jeromelaban jeromelaban left review comments

@Xiaoy312 Xiaoy312 Xiaoy312 approved these changes

@dr1rrb dr1rrb dr1rrb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add SafeArea
4 participants
@kazo0 @jeromelaban @Xiaoy312 @dr1rrb