Skip to content

Commit

Permalink
chore!: Remove SetterBase.set_Property
Browse files Browse the repository at this point in the history
  • Loading branch information
ramezgerges committed Sep 20, 2023
1 parent 975808a commit 43635aa
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 11 deletions.
3 changes: 3 additions & 0 deletions doc/articles/migrating-from-previous-releases.md
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,9 @@ This change has no effect on Controls behavior.
#### Change `RenderSurfaceType` namespace
There used two be two `RenderSurfaceType`s, `Uno.UI.Runtime.Skia.RenderSurfaceType` (for Gtk) and `Uno.UI.Skia.RenderSurfaceType` (for Skia). They are now `Uno.UI.Runtime.Skia.Gtk.RenderSurfaceType` and `Uno.UI.Runtime.Skia.Wpf.RenderSurfaceType` respectively.

#### Rmove `SetterBase.set_Property`
This method was only present for binary backward compatibility with `Setter<T>`. Use `Setter.Property` or `Setter<T>.Property` instead

#### `Panel`s no longer measure or arrange any children in `MeasureOverride` or `ArrangeOverride`, respectively
`Panel`s used to measure and arrange the first child in `MeasureOverride` or `ArrangeOverride`, respectively. This is no longer the case. Now, to match WinUI, `Panel`s just return an empty size in `MeasureOverride`, and the `finalSize` as is in `ArrangeOverride`. You should override these layout-override methods in `Panel`-derived subclasses instead.

Expand Down
2 changes: 0 additions & 2 deletions src/Uno.UI/UI/Xaml/Setter.Generic.cs
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ public Setter(string property, Action<T> action)
/// </summary>
public string Property { get; set; }

internal override void OnStringPropertyChanged(string name) => Property = name;

internal override void ApplyTo(DependencyObject o)
{
if (!(o is T))
Expand Down
9 changes: 0 additions & 9 deletions src/Uno.UI/UI/Xaml/SetterBase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,6 @@ internal SetterBase()

internal abstract void ApplyTo(DependencyObject o);

/// <summary>
/// This method is present for binary backward compatibility with <see cref="Setter{T}"/>.
/// Use <see cref="Setter.Property"/> or <see cref="Setter{T}.Property"/> instead.
/// </summary>
[EditorBrowsable(EditorBrowsableState.Never)]
public void set_Property(string name) => OnStringPropertyChanged(name);

internal virtual void OnStringPropertyChanged(string name) { }

partial void OnDataContextChangedPartial(DependencyPropertyChangedEventArgs e)
{
this.Log().Debug("SetterBase.DataContextChanged");
Expand Down

0 comments on commit 43635aa

Please sign in to comment.