Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync generator should generate attributes #10842

Closed
13 tasks
MartinZikmund opened this issue Dec 28, 2022 · 2 comments · Fixed by #11254
Closed
13 tasks

Sync generator should generate attributes #10842

MartinZikmund opened this issue Dec 28, 2022 · 2 comments · Fixed by #11254
Assignees
@Youssef1313
Labels
area/code-generation Categorizes an issue or PR as relevant to code generation difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/enhancement New feature or request project/core-tools 🛠️ Categorizes an issue or PR as relevant to core and tools

Comments

@MartinZikmund
Copy link
Member

What would you like to be added:

Almost all classes in UWP/WinUI have attributes declared. While some are not necessarily useful in Uno Platform context, some are, e.g. [ContentProperty].

Sync generator should generate these automatically if they are not present in non-generated code already.

Why is this needed:

Avoid missing attributes.

For which Platform:

  • WebAssembly
  • Android
  • iOS
  • macOS (AppKit)
  • Mac Catalyst
  • Skia
    • WPF
    • GTK (Linux)
    • Linux Framebuffer
    • Tizen
  • Windows
  • Build tasks
  • Solution Templates

Anything else we need to know?
@MartinZikmund MartinZikmund added kind/enhancement New feature or request triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI and removed triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Dec 28, 2022
@jeromelaban
Copy link
Member

Some of those attributes are not available on the project, if I'm not mistaken. We'll have to get them some other way.

@jeromelaban jeromelaban added area/code-generation Categorizes an issue or PR as relevant to code generation project/core-tools 🛠️ Categorizes an issue or PR as relevant to core and tools labels Jan 9, 2023
@Youssef1313 Youssef1313 self-assigned this Feb 1, 2023
@Youssef1313 Youssef1313 mentioned this issue Feb 8, 2023
Merged
6 tasks
@Youssef1313
Copy link
Member

This should be fixed by #11254

@MartinZikmund Feel free to re-open if there are still issues in this area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Youssef1313 Youssef1313

Labels
area/code-generation Categorizes an issue or PR as relevant to code generation difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/enhancement New feature or request project/core-tools 🛠️ Categorizes an issue or PR as relevant to core and tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(SyncGenerator): Generate missing attributes Youssef1313/uno
3 participants
@MartinZikmund @jeromelaban @Youssef1313