Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SyncGenerator): Generate missing attributes #11254

Merged

Conversation

Youssef1313
Copy link
Member

GitHub Issue (If applicable): closes #10842

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@Youssef1313 Youssef1313 marked this pull request as draft February 8, 2023 20:45
@Youssef1313 Youssef1313 force-pushed the issues/10842 branch 5 times, most recently from 8a1bca2 to a8c9add Compare February 12, 2023 08:57
@Youssef1313 Youssef1313 marked this pull request as ready for review February 14, 2023 13:25
@Youssef1313
Copy link
Member Author

@jeromelaban Could you take a look?

@jeromelaban
Copy link
Member

This one would make sense to move to the breaking changes branch

@Youssef1313 Youssef1313 changed the base branch from master to feature/breaking-changes February 17, 2023 14:47
@jeromelaban jeromelaban force-pushed the feature/breaking-changes branch from ce9150e to 89bef78 Compare March 7, 2023 02:56
@jeromelaban jeromelaban marked this pull request as draft March 22, 2023 14:33
@jeromelaban jeromelaban force-pushed the feature/breaking-changes branch from fbe92e0 to c4968a5 Compare March 30, 2023 18:27
@jeromelaban jeromelaban force-pushed the feature/breaking-changes branch 2 times, most recently from d5fe12a to d5f223d Compare May 1, 2023 13:28
@Youssef1313 Youssef1313 force-pushed the issues/10842 branch 2 times, most recently from eafe04f to f91bd41 Compare May 15, 2023 15:32
@Youssef1313 Youssef1313 marked this pull request as ready for review May 15, 2023 15:37
@Youssef1313 Youssef1313 force-pushed the issues/10842 branch 3 times, most recently from 6b30fd2 to 874d089 Compare May 17, 2023 10:14
@Youssef1313
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@jeromelaban jeromelaban merged commit 1f881e8 into unoplatform:feature/breaking-changes Jun 6, 2023
@Youssef1313 Youssef1313 deleted the issues/10842 branch June 6, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync generator should generate attributes
2 participants