Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty methods RestoreBindings and ClearBindings #13046

Open
Tracked by #8339
Youssef1313 opened this issue Jul 28, 2023 · 3 comments
Open
Tracked by #8339

Remove empty methods RestoreBindings and ClearBindings #13046

Youssef1313 opened this issue Jul 28, 2023 · 3 comments
Assignees
Labels
difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/breaking-change 💥 Categorizes an issue or PR as requiring a breaking change to be fixed. kind/enhancement New feature or request

Comments

@Youssef1313
Copy link
Member

/// <summary>
/// Restores the bindings that may have been cleared by <see cref="ClearBindings()"/>.
/// </summary>
/// <remarks>
/// Calling this method will specifically restore <see cref="UI.Xaml.Data.Binding.ElementName"/>
/// and <see cref="UI.Xaml.Data.Binding.Source"/> bindings, which are not restored as part of the
/// normal <see cref="DataContext"/> change flow.
/// </remarks>
public void RestoreBindings()
{
}
/// <summary>
/// Clears the bindings for the current binder.
/// </summary>
/// <remarks>
/// This method is used as an out-of-band replacement for setting the DataContext to null, which
/// in the case of two-way bindings, would send the fallback value if it has been set.
/// This method may also clear <see cref="UI.Xaml.Data.Binding.ElementName"/>
/// and <see cref="UI.Xaml.Data.Binding.Source"/> bindings, which need to be restored
/// using the <see cref="RestoreBindings()"/> method.
/// </remarks>
public void ClearBindings()
{
}

These should be deleted.

The generated code in DependencyObjectGenerator will need to be adjusted as well.

@Youssef1313 Youssef1313 added kind/enhancement New feature or request triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Jul 28, 2023
@Youssef1313 Youssef1313 self-assigned this Jul 31, 2023
@MartinZikmund MartinZikmund added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers and removed triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Sep 20, 2023
@mnajibi
Copy link

mnajibi commented Oct 6, 2023

Hi there! 👋

I noticed the issue #13046 in this repository, and I'm eager to contribute to its resolution. My name is Maryam.

Could you please assign this issue to me? I'm excited to dive in and start working on it. If there are any specific details or requirements I should be aware of, please let me know.

Looking forward to contributing to this project!

Thanks,
Maryam

mnajibi added a commit to mnajibi/uno that referenced this issue Oct 6, 2023
@jeromelaban
Copy link
Member

jeromelaban commented Oct 10, 2023

@MartinZikmund I don't think we'll be able to place this one in 5.0, we're late in the cycle.

@mnajibi Thanks for working on this one, though we've placed it in the wrong bucket at this time. Your change is correct, but we're not able to include it in our current master branch.

Thanks for trying out contributing to Uno Platform!

@sasakrsmanovic
Copy link
Contributor

@mnajibi Thanks for engaging. I'd love to see if there are any other issues you are interested in and to see how we can help you. Its great to see a fellow Canadian contribute. Most of our team is in Montreal and I am in Toronto.

@MartinZikmund MartinZikmund added the kind/breaking-change 💥 Categorizes an issue or PR as requiring a breaking change to be fixed. label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/breaking-change 💥 Categorizes an issue or PR as requiring a breaking change to be fixed. kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants