Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .NET 7 SDK #10122

Merged
merged 46 commits into from
Feb 15, 2023
Merged

Use .NET 7 SDK #10122

merged 46 commits into from
Feb 15, 2023

Conversation

Youssef1313
Copy link
Member

GitHub Issue (If applicable): closes #10120

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@gitpod-io
Copy link

gitpod-io bot commented Oct 11, 2022

src/global.json Outdated Show resolved Hide resolved
@jeromelaban
Copy link
Member

This change is going to impact the net6-mobile targets, which are not yet tested completely. Let's see what the build is saying first.

@jeromelaban jeromelaban marked this pull request as draft October 11, 2022 20:17
@Youssef1313
Copy link
Member Author

This change is going to impact the net6-mobile targets, which are not yet tested completely. Let's see what the build is saying first.

Sure. Let's get the build green first and discuss any potential issues after that.

@Youssef1313
Copy link
Member Author

Youssef1313 commented Oct 15, 2022

Workload installation failed: microsoft.android.sdk.darwin::33.0.0-rc.1.136 is not found in NuGet feeds https://api.nuget.org/v3/index.json".

@jeromelaban Do you know what controls the requested version? Is it on Microsoft side? I guess they should have this version on NuGet.org or bump the requested version to 33.0.0-rc.1.151 which is already on NuGet.org.

Edit: dotnet/installer#14776

@jeromelaban
Copy link
Member

It's controlled by Microsoft's workloads, that why I mentioned that we should wait for Microsoft's release of the MAUI 7 RC2 workloads. You can pause this PR for now.

@Youssef1313
Copy link
Member Author

It's controlled by Microsoft's workloads, that why I mentioned that we should wait for Microsoft's release of the MAUI 7 RC2 workloads.

I downgraded the version used in this PR to RC1 thinking it would address your concern. But still even in RC1 Microsoft is using a package version that's not on NuGet.org.

I can wait for MAUI use of RC2 if they'll fix the issue at that time.

@github-actions github-actions bot added area/build Categorizes an issue or PR as relevant to build infrastructure area/solution-templates Categorizes an issue or PR as relevant to the solution template labels Nov 4, 2022
@jeromelaban
Copy link
Member

We cannot merge this PR as is, as the .NET 6 portion of the build is building with .NET 7, causing this issue: dotnet/sdk#30103. The .NET 6 portion needs to build explicitly using .NET 6 installed, even if the build passes with .NET 7. We'll reevaluate when we can drop Xamarin and net6, likely during this year around .NET 8.

@jeromelaban jeromelaban marked this pull request as draft February 6, 2023 16:49
@jeromelaban
Copy link
Member

That being said, there are some portions of this PR that can be extracted (some legacy steps to remove).

@Youssef1313
Copy link
Member Author

@jeromelaban Is it good with the last commit?

@Youssef1313 Youssef1313 marked this pull request as ready for review February 6, 2023 17:26
@jeromelaban
Copy link
Member

No, this will not be enough. The uno-check versions must also be different and .NET 7 must not be installed at all when building for net6 jobs.

@github-actions github-actions bot added the area/code-generation Categorizes an issue or PR as relevant to code generation label Feb 8, 2023
@github-actions github-actions bot removed the area/code-generation Categorizes an issue or PR as relevant to code generation label Feb 8, 2023
@Youssef1313
Copy link
Member Author

@jeromelaban It should be good now :)

Copy link
Member

@jeromelaban jeromelaban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@jeromelaban jeromelaban merged commit 7a1c3c3 into unoplatform:master Feb 15, 2023
@Youssef1313 Youssef1313 deleted the pin-sdk branch February 15, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Categorizes an issue or PR as relevant to build infrastructure area/solution-templates Categorizes an issue or PR as relevant to the solution template
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pin .NET SDK version in global.json
2 participants