-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use .NET 7 SDK #10122
Use .NET 7 SDK #10122
Conversation
This change is going to impact the net6-mobile targets, which are not yet tested completely. Let's see what the build is saying first. |
Sure. Let's get the build green first and discuss any potential issues after that. |
@jeromelaban Do you know what controls the requested version? Is it on Microsoft side? I guess they should have this version on NuGet.org or bump the requested version to Edit: dotnet/installer#14776 |
It's controlled by Microsoft's workloads, that why I mentioned that we should wait for Microsoft's release of the MAUI 7 RC2 workloads. You can pause this PR for now. |
I downgraded the version used in this PR to RC1 thinking it would address your concern. But still even in RC1 Microsoft is using a package version that's not on NuGet.org. I can wait for MAUI use of RC2 if they'll fix the issue at that time. |
We cannot merge this PR as is, as the .NET 6 portion of the build is building with .NET 7, causing this issue: dotnet/sdk#30103. The .NET 6 portion needs to build explicitly using .NET 6 installed, even if the build passes with .NET 7. We'll reevaluate when we can drop Xamarin and net6, likely during this year around .NET 8. |
That being said, there are some portions of this PR that can be extracted (some legacy steps to remove). |
@jeromelaban Is it good with the last commit? |
No, this will not be enough. The uno-check versions must also be different and .NET 7 must not be installed at all when building for net6 jobs. |
@jeromelaban It should be good now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
GitHub Issue (If applicable): closes #10120
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Internal Issue (If applicable):