chore: Remove non-working caching unmodified xaml files #11452
Conversation
github-actions
bot
added
the
area/code-generation
| var outputFile = Path.Combine( | ||
| _targetPath, | ||
| $@"g\{typeof(XamlCodeGenerator).Name}\{_fileDefinition.UniqueID}.g.cs" | ||
| ); |
There was a problem hiding this comment.
By default, the files are not written to disk. So, in most cases this code does nothing.
The code isn't correct anyway. The fact that XAML file didn't change doesn't mean that the generated code will remain the same.
| @@ -202,11 +201,6 @@ public XamlCodeGeneration(GeneratorExecutionContext context) | |||
| _enableFuzzyMatching = true; | |||
| } | |||
|
|
|||
| _targetPath = Path.Combine( | |||
There was a problem hiding this comment.
We may still need that part for the uno.sourcegeneration side. We'll remove it when we remove Xamarin.
There was a problem hiding this comment.
@jeromelaban The comment was referring specifically to Roslyn, and the logic is not correct anyway. Do we still need to wait if the caching isn't guaranteed to be correct?
If we still want to keep it, should it be conditioned on !NETSTANDARD2_0?
There was a problem hiding this comment.
Yes let's keep it for !NETSTANDARD2_0 for now.
Youssef1313
force-pushed
the
xaml-unmodified
branch
from
90c936e to
6465583
Compare
GitHub Issue (If applicable): closes #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):