Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skia application lifecycle changes #12354

Closed
wants to merge 35 commits into from
Closed

Skia application lifecycle changes #12354

wants to merge 35 commits into from

Conversation

MartinZikmund
Copy link
Member

@MartinZikmund MartinZikmund commented May 18, 2023 •
edited
Loading

GitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@github-actions github-actions bot added area/automation Categorizes an issue or PR as relevant to project automation area/skia ✏️ Categorizes an issue or PR as relevant to Skia platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform labels May 18, 2023
@Youssef1313 Youssef1313 mentioned this pull request May 27, 2023
Open
@MartinZikmund MartinZikmund force-pushed the dev/mazi/gtk-wpf-windowing branch 2 times, most recently from 125658f to 5a839f5 Compare June 4, 2023 10:46
@github-actions github-actions bot added area/build Categorizes an issue or PR as relevant to build infrastructure area/code-generation Categorizes an issue or PR as relevant to code generation kind/documentation labels Jun 4, 2023
@MartinZikmund MartinZikmund force-pushed the dev/mazi/gtk-wpf-windowing branch from 5a839f5 to 5ed14f0 Compare June 4, 2023 10:50
@MartinZikmund MartinZikmund self-assigned this Jun 7, 2023
@MartinZikmund MartinZikmund force-pushed the dev/mazi/gtk-wpf-windowing branch 2 times, most recently from 7bcf257 to b982bda Compare June 8, 2023 08:38
@github-actions github-actions bot removed area/build Categorizes an issue or PR as relevant to build infrastructure kind/documentation area/code-generation Categorizes an issue or PR as relevant to code generation labels Jun 8, 2023
@MartinZikmund MartinZikmund changed the title [WIP] Skia application lifecycle changes Skia application lifecycle changes Jun 9, 2023
@MartinZikmund MartinZikmund marked this pull request as ready for review June 9, 2023 11:05
@MartinZikmund
chore: GTK rendering/host split, resturcturing runtime projects
7552148
@MartinZikmund
chore: Adjusting GTK window logic
94c3759
@MartinZikmund
chore: Adjusting renderers, temporary adjustments
4331d4a
@MartinZikmund
chore: Adjust WPF Window native overlay lifetime
902a12e
@MartinZikmund
chore: XamlRoot adjustments, internals
36407cc
@MartinZikmund
chore: Separate WPF window host and window itself
7632e77
@MartinZikmund
chore: Fix rendering issue on WPF OpenGL
1dca1aa
@MartinZikmund
chore: Refactor WPF renderer infrastructure
b0c601b
@MartinZikmund
chore: Move render invalidation to application level, finalize WPF re…
7fb07b0 
…factor
@MartinZikmund
chore: Shared overlay invalidation, restore WPF input
ee46dc3
@MartinZikmund
chore: Window reference changes
caae49c
@MartinZikmund
chore: Moving Window-related logic to window classes
1d09c5d
@MartinZikmund
chore: Adjust namespaces
6b1a34e
@MartinZikmund
chore: Adjust render surface initialization, GTK compiles
f058f8e
@MartinZikmund
chore: Adjusting ApplicationView and resizing
1582d8e
@MartinZikmund
chore: Adjust formatting
b5cce77
@MartinZikmund
chore: Adjust WASM activation
96bc6af
@MartinZikmund
chore: Adjust naming
6bc3d3a
@MartinZikmund
refactor: Share XamlRootMap implementation across target
4498874
@MartinZikmund
chore: Formatting, naming
7081e33
@MartinZikmund
chore: Adjust namings
f51a439
@MartinZikmund
chore: Adjustments to WPF extensions, refactoring of XamlRootMap
bc3953d
@MartinZikmund
chore: Adjust window startup
4ca9e2f
@MartinZikmund
chore: Set default window size
b72e2bf
@MartinZikmund MartinZikmund force-pushed the dev/mazi/gtk-wpf-windowing branch from 60f18d6 to b72e2bf Compare June 9, 2023 14:06
@jeromelaban jeromelaban deleted the branch unoplatform:feature/breaking-changes June 9, 2023 17:39
@jeromelaban jeromelaban closed this Jun 9, 2023
@MartinZikmund MartinZikmund mentioned this pull request Jun 9, 2023
Merged
6 tasks
@mergify
Copy link
Contributor

mergify bot commented Jun 9, 2023

⚠️ The sha of the head commit of this PR conflicts with #12597. Mergify cannot evaluate rules on this PR. ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MartinZikmund MartinZikmund

Labels
area/automation Categorizes an issue or PR as relevant to project automation area/skia ✏️ Categorizes an issue or PR as relevant to Skia platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MartinZikmund @jeromelaban