Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Align existing splash screen info, minor docs updates #14868

Merged
merged 6 commits into from
Dec 18, 2023

Conversation

lukeblevins
Copy link
Contributor

@lukeblevins lukeblevins commented Dec 18, 2023

This work is the first component to a larger effort around aligning + improving our resources for setup/customization of splash screens:

THIS PR

  • Positioning existing content as a manual option post-Resizetizer while still preserving docs relevant to that scenario

Next steps

  • Mentioning the toolkit's ExtendedSplashScreen as the recommended splash solution for GTK
  • Modifying bootstrapper repo page Splash screen customization to be a reference page for AppManifest.js properties: Preventing it from being used first by everyday consumers of splash screen
  • Expanding what the toolkit repo has documented for ExtendedSplashScreen

See: #14805

@github-actions github-actions bot added area/build Categorizes an issue or PR as relevant to build infrastructure kind/documentation labels Dec 18, 2023
@lukeblevins lukeblevins self-assigned this Dec 18, 2023
@lukeblevins lukeblevins changed the title docs: Align existing splash screen info, minor docsupdates docs: Align existing splash screen info, minor docs updates Dec 18, 2023
@lukeblevins lukeblevins marked this pull request as ready for review December 18, 2023 18:58
doc/articles/features/working-with-assets.md Outdated Show resolved Hide resolved
doc/articles/features/working-with-assets.md Outdated Show resolved Hide resolved
doc/articles/splash-screen.md Outdated Show resolved Hide resolved
doc/articles/splash-screen.md Outdated Show resolved Hide resolved
doc/articles/splash-screen.md Outdated Show resolved Hide resolved
Thanks Agnes!

Co-authored-by: Agnès ZITTE <16295702+agneszitte@users.noreply.github.com>
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-14868/index.html

@jeromelaban
Copy link
Member

@Mergifyio backport release/stable/5.0

@jeromelaban jeromelaban merged commit 30d27c9 into master Dec 18, 2023
14 checks passed
@jeromelaban jeromelaban deleted the dev/lubl/splash branch December 18, 2023 20:03
Copy link
Contributor

mergify bot commented Dec 18, 2023

backport release/stable/5.0

✅ Backports have been created

jeromelaban added a commit that referenced this pull request Dec 19, 2023
…5.0/pr-14868

docs: Align existing splash screen info, minor docs updates (backport #14868)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Categorizes an issue or PR as relevant to build infrastructure kind/documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants