Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix multiple docfx, css, js, mermaid layout related issues #16972

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

agneszitte
Copy link
Contributor

@agneszitte agneszitte commented Jun 1, 2024

GitHub Issue (If applicable): Resolves #8431, Resolves #14358, Resolves unoplatform/uno-private#453, Resolves #16100

PR Type

What kind of change does this PR introduce?

  • Bugfix

Description

Fix multiple docfx, css, js, mermaid layout related issues:

Before/After

Before After
code-snippet-tab-before code-snippet-tab-after
code-snippet-tab-dotnetcli-before code-snippet-tab-dotnetcli-after
code-snippet-tab-margin-before code-snippet-tab-margin-after
code-snippet-pwsh-before code-snippet-pwsh-after
mermaid-graph-display-before mermaid-graph-display-after

Before

<div style="position: relative; width: 100%; padding-bottom: 56.25%;">
    <iframe
        src="https://www.youtube-nocookie.com/embed/BQdj9rqLcos"
        title="YouTube video player"
        frameborder="0"
        allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share"
        allowfullscreen
        style="position: absolute; top: 0; left: 0; width: 100%; height: 100%;">
    </iframe>
</div> 

After
> [!Video https://www.youtube-nocookie.com/embed/BQdj9rqLcos]


Before

	``` csharp
	... code snippet
	```

After

	```csharp
	... code snippet
	```

PR Checklist

Please check if your PR fulfills the following requirements:

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16972/index.html

@agneszitte agneszitte force-pushed the dev/agzi/FixDocsLayoutIssues branch from f0fb0ad to ffd5af6 Compare June 3, 2024 13:07
@github-actions github-actions bot added the area/build Categorizes an issue or PR as relevant to build infrastructure label Jun 3, 2024
@agneszitte agneszitte force-pushed the dev/agzi/FixDocsLayoutIssues branch from ffd5af6 to 8c36dc2 Compare June 3, 2024 13:12
@github-actions github-actions bot removed the area/build Categorizes an issue or PR as relevant to build infrastructure label Jun 3, 2024
@agneszitte agneszitte force-pushed the dev/agzi/FixDocsLayoutIssues branch from 8c36dc2 to 031a26a Compare June 3, 2024 13:21
@agneszitte agneszitte marked this pull request as ready for review June 3, 2024 13:33
@agneszitte
Copy link
Contributor Author

@Mergifyio backport release/stable/5.2

Copy link
Contributor

mergify bot commented Jun 3, 2024

backport release/stable/5.2

✅ Backports have been created

@agneszitte agneszitte force-pushed the dev/agzi/FixDocsLayoutIssues branch from 031a26a to da3d3b8 Compare June 3, 2024 14:13
Copy link
Member

@morning4coffe-dev morning4coffe-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, going thought the pages, I don't see any issues and great job with making the Video markdown syntax work!

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16972/index.html

@agneszitte agneszitte merged commit 7dccddf into master Jun 3, 2024
15 checks passed
@agneszitte agneszitte deleted the dev/agzi/FixDocsLayoutIssues branch June 3, 2024 18:42
agneszitte added a commit that referenced this pull request Jun 3, 2024
…5.2/pr-16972

docs: Fix multiple docfx, css, js, mermaid layout related issues (backport #16972)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants