chore: Inspectable WebView not applied correctly #18199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform/macos 🍏
MartinZikmund
force-pushed
the
dev/mazi/inspectable-webview
branch
from
a5c1ec6
to
9e5ac59
Compare
|
@Mergifyio backport release/stable/5.4 |
🟠 Waiting for conditions to match
|
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18199/index.html |
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18199/index.html |
1 similar comment
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18199/index.html |
ajpinedam
reviewed
Sep 13, 2024
src/Uno.UI/UI/Xaml/Controls/WebView/Native/iOSmacOS/UnoWKWebView.iOSmacOS.cs
Show resolved
Hide resolved
jeromelaban
approved these changes
Sep 13, 2024
|
@Mergifyio backport release/stable/5.4 |
✅ Backports have been created
|
|
@ajpinedam looks like there's another build error. |
This Pr was created by @MartinZikmund , do you want me to look a the build error? |
|
I pushed a change to fix the CI. |
ajpinedam
approved these changes
Sep 13, 2024
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18199/index.html |
|
The build 139819 found UI Test snapshots differences: Details
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18199/index.html |
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18199/index.html |
|
The build 139909 found UI Test snapshots differences: Details
|
6 tasks
jeromelaban
added a commit
that referenced
this pull request
Sep 17, 2024
…5.4/pr-18199 chore: Inspectable WebView not applied correctly (backport #18199)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): follow up to #18074
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Inspectable was applied only Uno.UI was built with DEBUG flag
What is the new behavior?
Apply the flag always
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):