Skip to content
This repository has been archived by the owner on Jun 2, 2023. It is now read-only.

Further improvements to support .NET 6 migration #668

Closed
wants to merge 0 commits into from

Conversation

unquietwiki
Copy link
Collaborator

Hey @geoperez and crew. I had to re-install this for one of my employers, and used the opportunity to see if there was anything I was running into. I have yesterday's changes running fine; today's stuff is the start of some refactoring, which you might want to review before doing any more. Part of that may help with an issue I've run into, where a failed new password (because of requirements on SAMBA/AD), comes up as an incorrect current password error. I also ended up running this without Docker again; if there was an easier way to separate out & map the JSON config for that, I think it'd definitely help that use.

Hope you all are keeping safe & well.

@unquietwiki
Copy link
Collaborator Author

@geoperez Also, I dunno if you can update your AppVeyor config, but it's failing on .NET 6 builds; seems like it's using VS 2017 stuff.

@geoperez
Copy link
Member

Hi @unquietwiki , quick question. Why do you change from "var" to type in variable declarations?

I'll check the Appveyor thing.

@unquietwiki
Copy link
Collaborator Author

Hi @unquietwiki , quick question. Why do you change from "var" to type in variable declarations?

I'll check the Appveyor thing.

Yeah, I was hesitant on the var-change; but VS kept suggesting it, and it was coming up with suggestions that exposed the nullable types, so that seemed more intuitive. A lot of the stuff SonarLint flagged relates to either nulls, or reference issues.

@geoperez
Copy link
Member

AppVeyor settings have been updated.

@geoperez
Copy link
Member

The front-end build is failing.

@unquietwiki
Copy link
Collaborator Author

@geoperez Managed to catch me up early; cat woke me up. I re-added react as a direct-dependency, even though the Uno stuff loads it. Can run build on my machine just fine; not sure why it's failing in Appveyor. Both my machine & my other install are using Node 16.x, if that helps.

@geoperez
Copy link
Member

Let me try to test it on my local env.

@VM-Master
Copy link

Hi,
any updates regarding .NET Core Version? We wanna get rid of old unsupported .NET Core Version.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants