Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Lamp Effect Component #32

Merged
merged 4 commits into from
Oct 24, 2024
Merged

Added Lamp Effect Component #32

merged 4 commits into from
Oct 24, 2024

Conversation

rahul-vashishtha
Copy link
Member

No description provided.

@rahul-vashishtha
Copy link
Member Author

The transform: translateZ(1px) is the properties getting added to Spotlight and Glowing Light which should not be there.

Screenshot 2024-10-24 at 12 26 34 PM Screenshot 2024-10-24 at 12 26 27 PM

@rahul-vashishtha
Copy link
Member Author

Once this is resolved, the port will be ready for review.

@nathan-de-pachtere
Copy link
Contributor

The transform: translateZ(1px) is the properties getting added to Spotlight and Glowing Light which should not be there.

Screenshot 2024-10-24 at 12 26 34 PM Screenshot 2024-10-24 at 12 26 27 PM

vueuse/motion#157

@nathan-de-pachtere
Copy link
Contributor

@rahul-vashishtha Your problem it's a side effect of vueuse/motion as you mention, and I think for motion stuff it's better to use framework-agnostic library. Not only for motion but for every stuff that are browser native. Vueuse/motion is not so much active, so not good to include.

The code changes above are just an example with GSAP, but you could do the same with animate.js.

@rahul-vashishtha rahul-vashishtha marked this pull request as ready for review October 24, 2024 09:14
@rahul-vashishtha
Copy link
Member Author

@nathan-de-pachtere I have removed the vueuse/motion and made the animation css only.

I'm thinking of removing vueuse/motion permanently from the project in near future as it creates a lot of issues with different components.

@rahul-vashishtha rahul-vashishtha merged commit 529af0f into main Oct 24, 2024
@nathan-de-pachtere
Copy link
Contributor

Super nice in CSS only ;)

@rahul-vashishtha rahul-vashishtha added the add-request-feature Addition or request for new component or feature label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add-request-feature Addition or request for new component or feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants