Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .idea folder from git #27

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

GeorgiiFirsov
Copy link
Contributor

Solution for #22

@unterumarmung
Copy link
Owner

The idea was not only to remove .idea from git.

Making .idea version controlled is not a bad idea generally: https://intellij-support.jetbrains.com/hc/en-us/articles/206544839-How-to-manage-projects-under-Version-Control-Systems

In this project it contains info about code style: https://github.com/unterumarmung/fixed_string/blob/master/.idea/codeStyles/Project.xml

But it's not a very convenient way to define a code style for a C++ project, because we have a lot of tools and IDEs.

Instead of CLion-based code style checking we need to provide a clang-tidy config that defined code style.

@GeorgiiFirsov
Copy link
Contributor Author

Instead of CLion-based code style checking we need to provide a clang-tidy config that defined code style.

So this PR should be linked to #25 too. To be implemented...

@unterumarmung
Copy link
Owner

unterumarmung commented Aug 16, 2021

Instead of CLion-based code style checking we need to provide a clang-tidy config that defined code style.

So this PR should be linked to #25 too. To be implemented...

Not necessarily. #25 is about CI. This one is about changing a code style checks engine. But it can implemented here too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove CLion's .idea folder that contains code style checks
2 participants