Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add numeric conversion stoi #43

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add numeric conversion stoi #43

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f9725e
add numeric conversion stoi
abel-mak Jan 22, 2022
7c6715f
replace long type with auto in stoi
abel-mak Jan 22, 2022
30f078e
refactor code
abel-mak Feb 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions include/fixed_string.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,6 +615,44 @@ std::basic_ostream<TChar, TTraits>& operator<<(std::basic_ostream<TChar, TTraits
return out;
}

template <size_t N>
constexpr int stoi(const fixed_string<N>& str, int base = 10)
{
auto it = str.cbegin();
auto ite = str.cend();
Comment on lines +621 to +622
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, use more descriptive variable names


while (it != ite && std::isspace(*it) != 0)
{
it++;
}
int sign = 1;
if (it != ite && (*it == '-' || *it == '+'))
{
sign = (*it == '-') ? -1 : 1;
it++;
}
if (base == 16 && it != ite && it + 1 != ite && *it == '0' && std::tolower(*(it + 1)) == 'x')
{
it += 2;
}
int res = 0;
while (it != ite && std::isalnum(*it) != 0 && (base > 1 && base < 37))
{
const int tmp = res;

if (std::isdigit(*it) != 0 && ((*it) - '0') < base)
res = (res * base) + ((*it) - '0') * sign;
else if (std::isalpha(*it) != 0 && (9 + (std::tolower(*it) - 'a' + 1)) < base)
res = (res * base) + ((9 + (std::tolower(*it) - 'a' + 1))) * sign;
else
break;
if ((sign > 0 && tmp > res) || (sign < 0 && tmp < res))
throw std::out_of_range("fixedstr stoi");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the error name should be more descriptive, something like: "FIXSTR_PRETTY_FUNCTION + ": the value " + str + " is out of range"

Where FIXSTR_PRETTY_FUNCTION is defined like this (pseudocode):

#ifdef _MSC_VER
    #define FIXSTR_PRETTY_FUNCTION fixstr::fixed_string{__FUNCSIG__}
#else // clang, gcc and others
    #define FIXSTR_PRETTY_FUNCTION fixstr::fixed_string{__PRETTY_FUNCTION__}
#endif

it++;
}
return (res);
}

} // namespace fixstr

// hash support
Expand Down