Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused use of GITHUB_TOKEN #177

Merged
merged 1 commit into from
Oct 26, 2024
Merged

Conversation

deining
Copy link
Contributor

@deining deining commented Oct 26, 2024

This PR bumps dependencies to their latest versions.

@untitaker
Copy link
Owner

I don't think this is necessary, it's already bumped in Cargo.lock. Cargo.toml should only provide lower bounds. The removed GITHUB_TOKEN I can merge though (not sure why this was added anymore)

@deining
Copy link
Contributor Author

deining commented Oct 26, 2024

I don't think this is necessary, it's already bumped in Cargo.lock. Cargo.toml should only provide lower bounds.

I see. Reverted the change meanwhile.

The removed GITHUB_TOKEN I can merge though (not sure why this was added anymore)

We changed from unmaintained actions-rs/clippy-check to clechasseur/rs-clippy-check. The latter does not need/use the token line. So yes, please merge this. Thanks.

@untitaker untitaker changed the title Bump dependencies to their latest versions Remove unused use of GITHUB_TOKEN Oct 26, 2024
@untitaker untitaker merged commit ee11f1b into untitaker:main Oct 26, 2024
11 checks passed
@untitaker
Copy link
Owner

Thank you!

untitaker pushed a commit that referenced this pull request Oct 26, 2024
@deining deining deleted the bump-deps branch October 26, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants