Skip to content

Commit

Permalink
Fix: MSVC by default makes Debug build.
Browse files Browse the repository at this point in the history
Debug build on windows requires python debug libraries, which by default are not installed.
  • Loading branch information
ishkhan42 committed Jun 8, 2023
1 parent 7210d02 commit 0a6c40d
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,9 @@ def build_extension(self, ext):
# Set CMAKE_BUILD_PARALLEL_LEVEL to control the parallel build level
# across all generators.
build_args = []
if sys.platform.startswith('win32'):
build_args += ['--config', 'Release']

if 'CMAKE_BUILD_PARALLEL_LEVEL' not in os.environ:
# self.parallel is a Python 3 only way to set parallel jobs by hand
# using -j in the build_ext call, not supported by pip or PyPA-build.
Expand Down

0 comments on commit 0a6c40d

Please sign in to comment.