Clean case directory during preparation step #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Cleaning directory is crutial to avoid unexpected uptest behavior when the cases are changing between uptest run * The cases contents can change during the uptest version upgrade and when we use `--skip-delete` option * Without this change the uptest behavior is confusing the user, e.g. the `--skip-delete` option does not effectively work after the standard run because `03-delete.yaml` case is not getting removed from the case directory Signed-off-by: Yury Tsarev <yury@upbound.io>
Signed-off-by: Yury Tsarev <yury@upbound.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
--skip-deleteoption--skip-deleteoption does not effectively work after the standard run because03-delete.yamlcase is not getting removed from the case directoryI have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
updating local cache with test build version in sample configuration of https://github.com/upbound/configuration-aws-eks-karpenter/
running
make e2ethen running
make e2e SKIP_DELETE=--skip-deleteObserve that
/var/folders/sx/0tlfb9ys20bbqnszv3lw12m40000gn/T/uptest-e2e/caseis getting properly cleaned now, and03-delete.yamlis not there anymore