Switch from larger runners to ubuntu-22.04 runner for the CI jobs #184
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
sergenyalcin
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Thanks @ulucinar LGTM! Let's try these machines in providers.
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR prepares the
standard-runnersbranch, which has been forked from the main branch, to switch to theubuntu-22.04job runner from the larger runners that we currently employ. This branch will be available until we need it (until we move all the official providers under to thecrossplane-contriborg. We've moved https://github.com/upbound/provider-azuread repo under to thecrossplane-contriborganization and there are other official providers that are still under theupboundorg. The idea is to temporarily use this branch for the providers as we move them to thecrossplane-contriborganization and to test the ones that we have not yet moved with the standard runners.This will allow us to gradually transition to the standard runners in the official provider repos.
It will also allow us to check whether any CI jobs need larger runners in the official provider repositories.
A relevant PR is: #135
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Please see: crossplane-contrib/provider-upjet-azuread#106