Fix the value of the PROVIDER_PACKAGE_NAME env. variable for updoc #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
We've realized that the marketplace docs for
upbound/provider-azuread@v1.0.0and (previously) forupbound/provider-aws@v1.2.0are not available although the family provider docs are there. This PR attempts to fix the package name calculation. It turns out that thePROVIDER_NAME's value was not properly substituted.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
We will directly test in the official providers' CI pipelines.
Post merge note:
The reusable workflow for publishing marketplace docs for the monoliths succeeded for the above two providers: