[updoc] Check for errors while walking the filesystem #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add the input parameter "updoc-version" to parameterize the version of updoc being used in the "Updoc" workflow Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
ulucinar
changed the title
|
Successfully created backport PR #202 for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
@turkenf hit an issue while trying to publish marketplace documents of the
upbound/provider-terraformrepository.We've identified the configuration error in that repository to resolve that issue but we've also spotted an error checking bug in
updoc. This PR adds an error check while walking the filesystem to discover the docs to be published.It also parameterizes the
updocversion that a provider repo is using and sets the default to a version containing the new fix.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Locally reproduced the configuration issue and we now log the underlying error:
Post merge note:
We've also verified that the underlying errors are properly reported here: