Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example for provider config terraform for Azure #208

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Add example for provider config terraform for Azure #208

merged 1 commit into from
Nov 14, 2023

Conversation

jankaacc
Copy link
Contributor

@jankaacc jankaacc commented Nov 2, 2023

Description of your changes

Added example for initializing provider terraform for azure
tfvars file is used to do that

Fixes #

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

image

@Upbound-CLA
Copy link

Upbound-CLA commented Nov 2, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

bobh66
bobh66 reviewed Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@bobh66 bobh66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Would it make sense to include a copy of the azure-creds Secret so the format is clear? It's not immediately obvious to me where the values for subscriptionId/tenantId/clientId/clientSecret come from - I assume they are in the azure-secret?

ytsarev
ytsarev reviewed Nov 2, 2023
View reviewed changes
examples/providerconfig-azure.yaml
name: azure-westeurope
spec:
credentials:
- filename: terraform.tfvars.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is pretty cool trick, worth highlighting it with the comment :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had it at the beginning :) will add this

@jankaacc
Copy link
Contributor Author

jankaacc commented Nov 2, 2023

ediately obvious to me where the values for subscriptionId/tenantId/clientId/clientSecret come from - I assume they are in the azure-secret?

agree, will add this secret above the providerConfig

@jankaacc
Copy link
Contributor Author

jankaacc commented Nov 2, 2023

updated

ytsarev
ytsarev approved these changes Nov 4, 2023
View reviewed changes
Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jankaacc Great example, thanks a lot for the contribution 👍

@ytsarev
Copy link
Member

ytsarev commented Nov 4, 2023

@jankaacc can you please sign the CLA before we merge this one?

@ytsarev ytsarev merged commit e74e50b into upbound:main Nov 14, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobh66 bobh66 bobh66 left review comments

@ytsarev ytsarev ytsarev approved these changes

@negz negz Awaiting requested review from negz negz is a code owner

@ulucinar ulucinar Awaiting requested review from ulucinar ulucinar is a code owner

@sergenyalcin sergenyalcin Awaiting requested review from sergenyalcin sergenyalcin is a code owner

@turkenf turkenf Awaiting requested review from turkenf turkenf is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jankaacc @Upbound-CLA @ytsarev @bobh66