feat: adding support for defining the backend file content #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigorfk
requested review from
bobh66,
ytsarev,
negz,
ulucinar,
sergenyalcin and
turkenf
as code owners
|
|
bobh66
reviewed
Nov 21, 2023
rodrigorfk
force-pushed
the
feat-backend-file
branch
from
8ee1c24
to
ce5621d
Compare
|
Thanks for the suggestions @bobh66 , the changes were applied and a rebase was performed. |
ytsarev
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
LGTM
@rodrigorfk thanks a lot for the contribution!
@bobh66 do you have any other suggestion to this PR?
|
LGTM - thanks @rodrigorfk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This changes introduces the
backendFilefield in theProviderConfig, which allows defining the content for the terraform backend configuration file used duringterraform init.Fixes #212
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
ProviderConfigdefining thebackendFilefield and test it in aWorkspacecontaining partial backend configuration, I was able to validate the solution is working fine.