Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Supporting management policies beta feature #219

Merged
merged 1 commit into from
Dec 16, 2023

Conversation

caiofralmeida
Copy link
Contributor

Description of your changes

This PR enables the Beta feature management policies, following the same approach as the AWS provider.

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

The tests were done manually, applying the following scenarios:

  • Applying Workspace without management policies (management policy feature disabled)
  • Applying Workspace management policy [Observe] only (management policy feature disabled)
  • Applying Workspace management policy [Observe] only (management policy feature enabled)

@Upbound-CLA
Copy link

Upbound-CLA commented Nov 30, 2023

CLA assistant check
All committers have signed the CLA.

@ytsarev
Copy link
Member

ytsarev commented Dec 14, 2023

/test-examples="examples/workspace-inline-aws.yaml"

Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caiofralmeida Thanks a lot for your contribution!

@ytsarev ytsarev merged commit 743bb95 into upbound:main Dec 16, 2023
10 checks passed
@caiofralmeida
Copy link
Contributor Author

@ytsarev you are very welcome 🤝

@caiofralmeida caiofralmeida deleted the enable-management-policies branch December 26, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants