feat: introduce json format for inline module (#165) #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniskniep
requested review from
bobh66,
ytsarev,
negz,
ulucinar,
sergenyalcin and
turkenf
as code owners
|
|
bobh66
requested changes
Aug 8, 2024
| @@ -249,8 +250,12 @@ func (c *connector) Connect(ctx context.Context, mg resource.Managed) (managed.E | |||
| } | |||
|
|
|||
| case v1beta1.ModuleSourceInline: | |||
| if err := c.fs.WriteFile(filepath.Join(dir, tfMain), []byte(cr.Spec.ForProvider.Module), 0600); err != nil { | |||
| return nil, errors.Wrap(err, errWriteMain) | |||
| filename := tfMain | |||
There was a problem hiding this comment.
nit: I think we prefer short variable names, so maybe fn or f instead of filename
Signed-off-by: Dennis Kniep <kniepdennis@gmail.com>
denniskniep
force-pushed
the
feature/inline-module-format-json
branch
from
588d051
to
db0eb9e
Compare
|
@bobh66 addressed your review comments |
|
@bobh66 can we merge this? |
bobh66
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Thhanks @denniskniep - LGTM. It would be nice to have an example Workspace that shows the JSON format, but presumably anyone interested in using the JSON format already knows what it looks like.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
API Change:
Added a new property
InlineFormattoWorkspaceParameterswhich specifies the format of the inline Terraform content. It could beHCLorJSONChange:
If
InlineFormatis set toJSONthe file which is created is namedmain.tf.jsoninstead ofmain.tfFixes #165
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Wrote a UnitTest and already tested it in my environment