Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use data_block for extra pep #2

Merged
merged 2 commits into from
Jun 1, 2021
Merged

use data_block for extra pep #2

merged 2 commits into from
Jun 1, 2021

Conversation

plicease
Copy link
Member

@plicease plicease commented Jun 1, 2021

No description provided.

@plicease
Copy link
Member Author

plicease commented Jun 1, 2021

I think this diagnostic is actually a bug in Platypus or Archive::Libarchive:

t/00_diag.t ..................... ok   
t/archive_libarchive_extract.t .. 1/? Too much data: Truncating file at 6 bytes at t/archive_libarchive_extract.t line 92.
Too much data: Truncating file at 6 bytes at t/archive_libarchive_extract.t line 92.
Too much data: Truncating file at 6 bytes at t/archive_libarchive_extract.t line 92.
Too much data: Truncating file at 6 bytes at t/archive_libarchive_extract.t line 92.
t/archive_libarchive_extract.t .. ok   
t/examples.t .................... ok   

@plicease
Copy link
Member Author

plicease commented Jun 1, 2021

I think this diagnostic is actually a bug in Platypus or Archive::Libarchive:

t/00_diag.t ..................... ok   
t/archive_libarchive_extract.t .. 1/? Too much data: Truncating file at 6 bytes at t/archive_libarchive_extract.t line 92.
Too much data: Truncating file at 6 bytes at t/archive_libarchive_extract.t line 92.
Too much data: Truncating file at 6 bytes at t/archive_libarchive_extract.t line 92.
Too much data: Truncating file at 6 bytes at t/archive_libarchive_extract.t line 92.
t/archive_libarchive_extract.t .. ok   
t/examples.t .................... ok   

Spent some time in gdb and I think this is a bug or at least inconsistency in the libarchive API, but it is easy to work around. 95a7c29 should fix it.

@plicease plicease merged commit 4a23e49 into main Jun 1, 2021
@plicease plicease deleted the graham/data-block branch June 1, 2021 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant