Add sorting of require statements with autofix #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satazor
force-pushed
the
use-new-sort-imports-require-plugin
branch
6 times, most recently
from
46e1070
to
95c4007
Compare
This commit also adds autofix for import statements. Please note that Node.js min version is now 14.
satazor
force-pushed
the
use-new-sort-imports-require-plugin
branch
from
95c4007
to
ff92937
Compare
nunofgs
approved these changes
Feb 25, 2022
|
This change would have single-handedly rendered a considerable chunk of past code review comments unnecessary, if memory serves me well. Nice work, @satazor! ❤️ |
|
Thank you @waldyrious |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit also adds autofix for import statements.
I've tested this in the
backendandfrontend-clientsand is working nicely.Please note that both diffs contain changes due to #52.
The
backendcontains a lot of changes due tolodashnow being placed properly in its place as well as other situations were require statements order was wrong.Both diffs contain small changes related to wrong usage of
map,filterand other functions where we were not returning anything. This is because we enabledarray-callback-returnin #52