Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Complete tsconfig file Overwriting #388

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

Eprince-hub
Copy link
Member

Implement a merge strategy for tsconfig.json files to combine existing configurations with new template configurations during the UpLeveled ESLint config installation, to preserve paths and other settings and solve the TypeScript error in react native expo projects

@Eprince-hub Eprince-hub self-assigned this Jun 19, 2024
Copy link

socket-security bot commented Jun 20, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/comment-json@4.2.3 None 0 46.3 kB kael

View full report↗︎

pnpm-lock.yaml Outdated
Comment on lines 109 to 111
resolution: {integrity: sha512-1Yjs2SvM8TflER/OD3cOjhWWOZb58A2t7wpE2S9XfBYTiIl+XFhQG2bjy4Pu1I+EAlCNUzRDYDdFwFYUKvXcIA==}
engines: {node: '>=0.10.0'}
resolution:
{
integrity: sha512-1Yjs2SvM8TflER/OD3cOjhWWOZb58A2t7wpE2S9XfBYTiIl+XFhQG2bjy4Pu1I+EAlCNUzRDYDdFwFYUKvXcIA==,
}
engines: { node: '>=0.10.0' }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah it seems like this file has been formatted by Prettier or something, we can probably revert the changes here and then re-run pnpm install to generate a minimal diff

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karlhorky
Copy link
Member

@Eprince-hub probably this will be simpler with is-plain-obj, as shown here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants